Uploaded image for project: 'SLF4J'
  1. SLF4J
  2. SLF4J-560

Clarify Logger.makeLoggingEventBuilder() method semantics

    XMLWordPrintable

Details

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.0.1
    • 2.0.0
    • None
    • None

    Description

      The various atXYZ methods in Logger first perform a check whether the logger is enabled for the given level and if enabled, invoke makeLoggingEventBuilder which performs a check a second time. This is wasteful and unnecessary.

      Moreover, it makes the API needlessly confusing.

      The makeLoggingEventBuilder should have one task and that is building the appropriate LoggingEventBuilder instance as appropriate for the logging backend.

      This change should not effect existing implementations as the removal of the duplicate check is confusing but not actually harmful.

      Attachments

        Activity

          People

            ceki Ceki Gülcü
            ceki Ceki Gülcü
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: