Details
-
Bug
-
Resolution: Fixed
-
Critical
-
2.0.0
-
None
-
None
Description
The various atXYZ methods in Logger first perform a check whether the logger is enabled for the given level and if enabled, invoke makeLoggingEventBuilder which performs a check a second time. This is wasteful and unnecessary.
Moreover, it makes the API needlessly confusing.
The makeLoggingEventBuilder should have one task and that is building the appropriate LoggingEventBuilder instance as appropriate for the logging backend.
This change should not effect existing implementations as the removal of the duplicate check is confusing but not actually harmful.
Attachments
Issue Links
- subsumes
-
SLF4J-559 Logger.atLevel(Level) always returns an enabled builder
- Resolved
- links to