Uploaded image for project: 'SLF4J'
  1. SLF4J
  2. SLF4J-554

MessageFormatter refactor (declare field variable, naming, not used variable)

    XMLWordPrintable

Details

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • None
    • None
    • None
    • normal

    Description

      I changed three things from MessageFormatter class.

      First, declare field variables in for-loop.
      Before I change, field variables named "j", "l" declared outside the for-loop. I thought that it was because of the performance. but from performance perspective, It was not faster than declaring in for-loop (rather, the latter was faster). So, I changed these based on a maintenance perspective. "declare where use."

      Second, There was wrong spelled method in messageFormatter (isEscapedDelimeter -> isEscapedDelimiter). It is only used in same class. So I changed.

      Last, static char `DELIM_STOP` never used in messageFormatter class. so I deleted.

       

      this is my first time to contribute! 

      Attachments

        Activity

          People

            slf4j-dev SLF4J developers list
            huni jaehunchoi
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: