Uploaded image for project: 'SLF4J'
  1. SLF4J
  2. SLF4J-409

Logging null messages

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.0-beta3
    • Component/s: jul-to-slf4j
    • Labels:
      None
    • Severity:
      minor

      Description

      Copied from message I sent to mailing list.

       

      While searching through the logging framework(s) to see why something was being logged as it was, I came across some curious code (unrelated to my issue).
       
      https://github.com/qos-ch/slf4j/blob/1c6cbf05e6a99a8805397d1c06008021fdc96527/jul-to-slf4j/src/main/java/org/slf4j/bridge/SLF4JBridgeHandler.java#L294-L301
       
      While the comment seems valid, `message` is an otherwise unused local variable. If the comment is still relevant, and I'm not going crazy, I'm assuming it should instead be `record.setMessage("")`?
       
      Cheers,
      -Devin

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ceki Ceki Gülcü
              Reporter:
              thundza Devin Smith
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: