Uploaded image for project: 'logback'
  1. logback
  2. LOGBACK-288

Improve WriterAppender

    XMLWordPrintable

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • None
    • logback-core
    • None
    • Operating System: All
      Platform: All

    • 115

    Description

      Reviewing the ch.qos.logback.core.WriterAppender class, I see that the attributes are 'protected' (not 'private'). However, there are set and get methods for most of them (but not all).

      I suggest making the attributes private and create setters and getters for all of them (there is no getWriter() for instance). This would prevent subclasses from incorrectly working directly against the attributes (for instance, not using the setWriter() would cause errors). If some 'public' getters are not desirable, at least 'protected' ones should be provided.

      Attachments

        Activity

          People

            logback-dev Logback dev list
            andham Anders Hammar
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: