Uploaded image for project: 'logback'
  1. logback
  2. LOGBACK-1558

Fix for code that fails existing tests

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.3.0-alpha6
    • Fix Version/s: None
    • Labels:
      None

      Description

      I have implemented a fix for the code that fails the following tests:

      • ch.qos.logback.classic.joran.JoranConfiguratorTest,
      • ch.qos.logback.core.rolling.helper.RollingCalendarTest

      RollingCalendar had an issue when detecting collisions - there was a case when the first day of a year is not exactly within the first week of a year.

      JoranConfigurator did not correctly resolve appender refs (eg. AsyncAppenderBase was started too early, before all appenders were attached to it) and I delayed the start of appenders after the whole configuration is built.

      I have added a pull request with my fixes on GitHub.

      https://github.com/qos-ch/logback/pull/518

        Attachments

          Activity

            People

            Assignee:
            logback-dev Logback dev list
            Reporter:
            multicatch Cezary Regec
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: