Uploaded image for project: 'logback'
  1. logback
  2. LOGBACK-1400

Let ResilientOutputStreamBase.openNewOutputStream() be override from outside the package

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.3.0-alpha4
    • Fix Version/s: None
    • Component/s: logback-core
    • Labels:
      None

      Description

      Let ResilientOutputStreamBase.openNewOutputStream() be override from outside the package.

      This method is currently package protected which means only subclasses in the same package can override this method. When other frameworks like Dropwizard want to provide their own implementation of a ResilientOutputStream they have to put their class in the ch.qos.logback.core.recovery package. Which causes a split package problem when using Java 9 modules: https://github.com/dropwizard/dropwizard/issues/2312

      If this method is meant to be overridden from outside logback-core, a "protected" modifier should be added.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              logback-dev Logback dev list
              Reporter:
              pstorch Peter Storch
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: