Uploaded image for project: 'logback'
  1. logback
  2. LOGBACK-102

Unsecure usage of locks in AppenderAttachableImpl

    XMLWordPrintable

Details

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • None
    • logback-core
    • None

    Description

      The unlock of a lock should, I would even say "must", always be done in
      a finally block. Otherwise really bad things (deadlock) can happen if an exception
      is thrown.

      See http://java.sun.com/j2se/1.5.0/docs/api/java/util/concurrent/locks/Lock.html

      Attachments

        1. LockPatch.patch
          3 kB
          Joern Huxhorn
        2. LockPatchWithTest.patch
          7 kB
          Joern Huxhorn
        3. LockPatchWithTest2.patch
          7 kB
          Joern Huxhorn

        Activity

          People

            logback-dev Logback dev list
            jhuxhorn Joern Huxhorn
            Votes:
            2 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: