Uploaded image for project: 'logback-access'
  1. logback-access
  2. ACCCESS-1

Implement getCookies, getLocalPort, and getLocalAddr methods in RequestWrapper

    XMLWordPrintable

Details

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • None
    • jetty 12
    • None

    Description

      Logback Access 2.0.1 and Jetty 12.

      The methods getCookies, getLocalPort, and getLocalAddr currently exist within the RequestWrapper class but do not return meaningful data as one might expect.

      These methods will be used in my project and I expect to improve them.
      Moreover, the improvements to getCookies and getLocalPort methods are useful as they correlate with the values used in logback-access's pattern layouts, such as %reqCookie for cookies and %localPort for the local port. (For some reason, %localIP works without the getLocalAddr implementation.

      I propose the following changes:

      getCookies(): This method should be improved to convert and return an array of Cookie objects, derived from the List<HttpCookie> returned by Request::getCookies.
      getLocalPort(): By using Request::getLocalPort, this method could be improved to return the port number.
      getLocalAddr(): Similarly by using Request::getLocalAddr, this method could be improved to return the local address.

      Attachments

        Activity

          People

            ceki Ceki Gülcü
            ceki Ceki Gülcü
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: