Details
-
Bug
-
Resolution: Fixed
-
None
-
1.5.x
-
None
-
Operating System: Mac OS X 10.0
Platform: Macintosh
-
blocker
-
P1
-
90
Description
The generic log method in slf4j-jdk14 is missing a wrapper to test if the level is loggable:
if (logger.isLoggable(julLevel)) {
Without it, the stack trace elements are getting created from org.apache.commons.logging.impl.SLF4JLocationAwareLog unconditionally.
I suggest changing this method as follows:
public void log(Marker marker, String callerFQCN, int level, String message,
Throwable t) {
Level julLevel;
switch (level)
if (logger.isLoggable(julLevel))
{ log(callerFQCN, julLevel, message, t); }}