From 48f457afae1540c4a5fa0aa17e36d55e1ba9ae42 Thu, 15 Nov 2012 08:54:17 +0100 From: Krzysztof Daniel Date: Thu, 15 Nov 2012 08:53:44 +0100 Subject: [PATCH] Avoid cyclic dependencies between packages declarations. The general pattern is that the API package exports API classes and does not require impl classes. slf4j was breaking that causing "A cycle was detected when generating the classpath slf4j.api, slf4j.nop, slf4j.api." The API bundle requires impl package, so to avoid cyclic dependencies during build time, it is necessary to mark the imported package as an optional one. diff --git a/slf4j-fix-cyclic-package-dependencies.patch b/slf4j-fix-cyclic-package-dependencies.patch new file mode 100644 index 0000000..1af0b21 --- /dev/null +++ b/slf4j-fix-cyclic-package-dependencies.patch @@ -0,0 +1,8 @@ +--- slf4j-api/src/main/resources/META-INF/MANIFEST.MF.bak 2009-12-30 17:15:48.000000000 +0100 ++++ slf4j-api/src/main/resources/META-INF/MANIFEST.MF 2012-11-14 21:53:18.731573100 +0100 +@@ -5,4 +5,4 @@ + Bundle-Vendor: SLF4J.ORG + Bundle-RequiredExecutionEnvironment: J2SE-1.3 + Export-Package: org.slf4j;version=${parsedVersion.osgiVersion}, org.slf4j.spi;version=${parsedVersion.osgiVersion}, org.slf4j.helpers;version=${parsedVersion.osgiVersion} +-Import-Package: org.slf4j.impl;version=${slf4j.api.minimum.compatible.version} ++Import-Package: org.slf4j.impl;version=${slf4j.api.minimum.compatible.version};resolution:=optional