Uploaded image for project: 'SLF4J'
  1. SLF4J
  2. SLF4J-466

EventRecordingLogger does not properly support the Throwable as last parameter

Details

    Description

      As per FAQ if the last parameter is a Throwable it should be accepted as the thing you want the stacktrace off.

      In the current EventRecordingLogger implementation, in case you pass two or more objects to the logger the (optional) last Throwable is seen as just an argument and not the actual Throwable.

       

      This issue also affects 1.8.x and 2.0.x.

      Attachments

        Activity

          [SLF4J-466] EventRecordingLogger does not properly support the Throwable as last parameter

          Ceki Gülcü added a comment - - edited

          Fixed in commit 4ed244 in master.

          fixed in 1.7-maintenance in commit a7562

          Ceki Gülcü added a comment - - edited Fixed in commit 4ed244 in master. fixed in 1.7-maintenance in commit a7562

          Ceki Gülcü added a comment -

          Yes, please that would be quite nice.

          Ceki Gülcü added a comment - Yes, please that would be quite nice.

          Wessel van Norel added a comment -

          Should I backport the changes to 1.7.x?

          Wessel van Norel added a comment - Should I backport the changes to 1.7.x?

          Wessel van Norel added a comment -

          I just created a pull request for this issue. By adding the test I also found another bug, one of the warn methods was missing the marker argument. As you can see in the commit: https://github.com/delgurth/slf4j/commit/b99ad9f80f937a91209accd9561332bb9fa30312

          The pull request: https://github.com/qos-ch/slf4j/pull/215

          Wessel van Norel added a comment - I just created a pull request for this issue. By adding the test I also found another bug, one of the warn methods was missing the marker argument. As you can see in the commit: https://github.com/delgurth/slf4j/commit/b99ad9f80f937a91209accd9561332bb9fa30312 The pull request: https://github.com/qos-ch/slf4j/pull/215

          People

            ceki Ceki Gülcü
            delgurth Wessel van Norel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: