Uploaded image for project: 'logback'
  1. logback
  2. LOGBACK-1183

Message formatting regression

    XMLWordPrintable

Details

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • 1.5.5
    • 1.1.0
    • None
    • None

    Description

      Commit c96dde98f3a0a816173943a20b47447de8eb124a introduced a regression to message formatting and throwable handling.

      To locate this commit yourself:
      1. Put attached LoggerMessageFormattingRegressionTest.java into logback-classic/src/test/java/ch/qos/logback/classic.
      2. Put attached bisect.sh into repository root and make it executable.

      git bisect start
      git bisect good 6c06412cab0e634f7410ff619fb92fe663ca5058
      git bisect bad 8c26f3b32cb386b1c1c3ae8dd14c6cf65c2c2578
      git bisect run ./bisect.sh
      

      "param1={}, param2={}, param3={}, exceptionString={}" with params

      new Object[]{"One", "Two", "Three", new RuntimeException("Exception-Message")}
      

      returns
      "param1=One, param2=Two, param3=Three, exceptionString={}" and has a ThrowableProxy
      instead of returning
      "param1=One, param2=Two, param3=Three, exceptionString=java.lang.RuntimeException: Exception-Message" with no ThrowableProxy.

      I have some more complaints about message formatting behavior but this one is an actual regression.

      Attachments

        Activity

          People

            logback-dev Logback dev list
            jhuxhorn Joern Huxhorn
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: