Uploaded image for project: 'logback'
  1. logback
  2. LOGBACK-290

Change file input buffer size of 8102 bytes to 8192 bytes in Compressor class

    XMLWordPrintable

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • None
    • None
    • logback-core
    • None

    Description

      in logback/core/rolling/helper/Compressor.java, there are two

      byte[] inbuf = new byte[8102];

      any particular reason not to use 8192 as buffer size ?

      Also worth to extract a constant for both buffer sizes, IMO.

      Attachments

        Activity

          People

            ceki Ceki Gülcü
            giantchen Shuo Chen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: