DBAppender: Support long event_id values in logging_event

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.18
  • Fix Version/s: None
  • Component/s: appender
  • Labels:
    None

Description

Want to retain longer history of logging events.
  1. Java Source File
    DBAppender.java
    22/Mar/10 8:45 PM
    7 kB
    Michael Lynch
  2. Java Source File
    DBAppenderBase.java
    22/Mar/10 8:45 PM
    5 kB
    Michael Lynch

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Lynch added a comment -
Attached changes to core.db.DBAppenderBase and classic.db.DBAppender.
Show
Michael Lynch added a comment - Attached changes to core.db.DBAppenderBase and classic.db.DBAppender.
Hide
Permalink
Ceki Gulcu added a comment -
In java 'int' is 32 bits, ranging from approx -2Billion to 2billion. Why would you ever want 'long' (64bit) event_id values?
Show
Ceki Gulcu added a comment - In java 'int' is 32 bits, ranging from approx -2Billion to 2billion. Why would you ever want 'long' (64bit) event_id values?
Hide
Permalink
Rü added a comment -
Actually we produce on average about 1 GB of logs per day... for one application only! I haven't counted the actual log statements issued, but it's ~25 million lines. We don't throw any logs away, so it would not take too long for the 2 billion limit to be reached. And I don't think we are an absolute extreme, are we?
Show
Rü added a comment - Actually we produce on average about 1 GB of logs per day... for one application only! I haven't counted the actual log statements issued, but it's ~25 million lines. We don't throw any logs away, so it would not take too long for the 2 billion limit to be reached. And I don't think we are an absolute extreme, are we?
Hide
Permalink
Joern Huxhorn added a comment -
I'd also vote for 64bits here.

If something really big is logging (e.g. Google) than 2 billion isn't really unrealistic. I'd always go for 64bit ids, simply to stay on the safe side.
Show
Joern Huxhorn added a comment - I'd also vote for 64bits here. If something really big is logging (e.g. Google) than 2 billion isn't really unrealistic. I'd always go for 64bit ids, simply to stay on the safe side.
Hide
Permalink
Ceki Gulcu added a comment -
Fixed in a recent commit.
Show
Ceki Gulcu added a comment - Fixed in a recent commit.

People

  • Assignee:
    Ceki Gulcu
    Reporter:
    Michael Lynch
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: